Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 936663005: Land https://codereview.chromium.org/889083003/ to update libsrtp to upstream 1.5.0 (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5449 lines, -1550 lines) Patch
M README.chromium View 2 chunks +10 lines, -7 lines 0 comments Download
M config/config.h View 1 chunk +10 lines, -2 lines 0 comments Download
M libsrtp.gyp View 8 chunks +55 lines, -4 lines 0 comments Download
M srtp/.cvsignore View 1 chunk +0 lines, -7 lines 0 comments Download
A srtp/.gitignore View 1 chunk +48 lines, -0 lines 0 comments Download
M srtp/CHANGES View 1 chunk +44 lines, -0 lines 0 comments Download
M srtp/Makefile View 1 chunk +0 lines, -237 lines 0 comments Download
M srtp/Makefile.in View 12 chunks +90 lines, -19 lines 0 comments Download
M srtp/README View 6 chunks +14 lines, -6 lines 0 comments Download
M srtp/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M srtp/crypto/Makefile View 1 chunk +0 lines, -137 lines 0 comments Download
M srtp/crypto/Makefile.in View 5 chunks +14 lines, -40 lines 0 comments Download
M srtp/crypto/ae_xfm/xfm.c View 1 chunk +0 lines, -605 lines 0 comments Download
M srtp/crypto/cipher/aes.c View 19 chunks +106 lines, -21 lines 0 comments Download
M srtp/crypto/cipher/aes_cbc.c View 10 chunks +46 lines, -21 lines 0 comments Download
A srtp/crypto/cipher/aes_gcm_ossl.c View 1 chunk +571 lines, -0 lines 0 comments Download
M srtp/crypto/cipher/aes_icm.c View 13 chunks +44 lines, -18 lines 0 comments Download
A srtp/crypto/cipher/aes_icm_ossl.c View 1 chunk +564 lines, -0 lines 0 comments Download
M srtp/crypto/cipher/cipher.c View 16 chunks +105 lines, -14 lines 0 comments Download
M srtp/crypto/cipher/null_cipher.c View 6 chunks +12 lines, -2 lines 0 comments Download
M srtp/crypto/hash/auth.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/hash/hmac.c View 1 chunk +4 lines, -0 lines 0 comments Download
A srtp/crypto/hash/hmac_ossl.c View 1 chunk +303 lines, -0 lines 0 comments Download
M srtp/crypto/hash/null_auth.c View 1 chunk +3 lines, -0 lines 0 comments Download
M srtp/crypto/hash/sha1.c View 1 chunk +3 lines, -0 lines 0 comments Download
M srtp/crypto/include/aes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M srtp/crypto/include/aes_cbc.h View 3 chunks +5 lines, -2 lines 0 comments Download
A srtp/crypto/include/aes_gcm_ossl.h View 1 chunk +64 lines, -0 lines 0 comments Download
M srtp/crypto/include/aes_icm.h View 4 chunks +6 lines, -2 lines 0 comments Download
A srtp/crypto/include/aes_icm_ossl.h View 1 chunk +86 lines, -0 lines 0 comments Download
M srtp/crypto/include/cipher.h View 7 chunks +36 lines, -12 lines 0 comments Download
M srtp/crypto/include/crypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M srtp/crypto/include/crypto_kernel.h View 1 chunk +2 lines, -1 line 0 comments Download
M srtp/crypto/include/crypto_types.h View 2 chunks +29 lines, -1 line 0 comments Download
M srtp/crypto/include/datatypes.h View 6 chunks +13 lines, -4 lines 0 comments Download
M srtp/crypto/include/err.h View 5 chunks +6 lines, -5 lines 0 comments Download
M srtp/crypto/include/hmac.h View 2 chunks +5 lines, -1 line 0 comments Download
M srtp/crypto/include/integers.h View 3 chunks +2 lines, -3 lines 0 comments Download
M srtp/crypto/include/kernel_compat.h View 1 chunk +1 line, -1 line 0 comments Download
M srtp/crypto/include/prng.h View 2 chunks +6 lines, -0 lines 0 comments Download
M srtp/crypto/include/rdb.h View 2 chunks +2 lines, -1 line 0 comments Download
M srtp/crypto/include/rdbx.h View 1 chunk +1 line, -0 lines 0 comments Download
M srtp/crypto/include/sha1.h View 2 chunks +40 lines, -0 lines 0 comments Download
M srtp/crypto/include/xfm.h View 1 chunk +1 line, -0 lines 0 comments Download
M srtp/crypto/kernel/alloc.c View 3 chunks +9 lines, -3 lines 0 comments Download
M srtp/crypto/kernel/crypto_kernel.c View 10 chunks +31 lines, -4 lines 0 comments Download
M srtp/crypto/kernel/err.c View 4 chunks +7 lines, -3 lines 0 comments Download
M srtp/crypto/kernel/key.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/math/datatypes.c View 3 chunks +36 lines, -185 lines 0 comments Download
M srtp/crypto/math/gf2_8.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/math/math.c View 2 chunks +5 lines, -1 line 0 comments Download
M srtp/crypto/math/stat.c View 2 chunks +5 lines, -0 lines 0 comments Download
M srtp/crypto/replay/rdb.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/replay/rdbx.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/replay/ut_sim.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/rng/ctr_prng.c View 3 chunks +9 lines, -3 lines 0 comments Download
M srtp/crypto/rng/prng.c View 1 chunk +4 lines, -0 lines 0 comments Download
A srtp/crypto/rng/rand_source_ossl.c View 1 chunk +71 lines, -0 lines 0 comments Download
M srtp/crypto/test/aes_calc.c View 3 chunks +6 lines, -1 line 0 comments Download
M srtp/crypto/test/cipher_driver.c View 13 chunks +102 lines, -14 lines 0 comments Download
M srtp/crypto/test/datatypes_driver.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/test/env.c View 3 chunks +4 lines, -0 lines 0 comments Download
M srtp/crypto/test/kernel_driver.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/test/rand_gen.c View 1 chunk +4 lines, -0 lines 0 comments Download
A srtp/crypto/test/rand_gen_soak.c View 1 chunk +118 lines, -0 lines 0 comments Download
M srtp/crypto/test/sha1_driver.c View 1 chunk +6 lines, -0 lines 0 comments Download
M srtp/crypto/test/stat_driver.c View 8 chunks +81 lines, -9 lines 0 comments Download
M srtp/doc/Makefile View 1 chunk +0 lines, -44 lines 0 comments Download
M srtp/include/srtp.h View 9 chunks +264 lines, -4 lines 0 comments Download
M srtp/include/srtp_priv.h View 4 chunks +14 lines, -1 line 0 comments Download
M srtp/srtp.def View 1 chunk +0 lines, -1 line 0 comments Download
M srtp/srtp/ekt.c View 7 chunks +7 lines, -6 lines 0 comments Download
M srtp/srtp/srtp.c View 48 chunks +1083 lines, -56 lines 0 comments Download
M srtp/tables/aes_tables.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/test/lfsr.c View 2 chunks +5 lines, -5 lines 0 comments Download
M srtp/test/rdbx_driver.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/test/replay_driver.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/test/roc_driver.c View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/test/rtp.c View 2 chunks +1 line, -1 line 0 comments Download
A srtp/test/rtp_decoder.h View 1 chunk +120 lines, -0 lines 0 comments Download
A srtp/test/rtp_decoder.c View 1 chunk +516 lines, -0 lines 0 comments Download
M srtp/test/rtpw.c View 10 chunks +123 lines, -19 lines 0 comments Download
M srtp/test/rtpw_test.sh View 3 chunks +53 lines, -2 lines 0 comments Download
A srtp/test/rtpw_test_gcm.sh View 1 chunk +239 lines, -0 lines 0 comments Download
M srtp/test/srtp_driver.c View 8 chunks +125 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936663005/1
5 years, 10 months ago (2015-02-23 19:14:51 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-23 19:14:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936663005/1
5 years, 10 months ago (2015-02-23 19:15:52 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
5 years, 10 months ago (2015-02-23 19:16:04 UTC) #8
jiayl
Committed patchset #1 (id:1) manually as r294175 (presubmit successful).
5 years, 10 months ago (2015-02-23 19:16:45 UTC) #9
jiayl
5 years, 10 months ago (2015-02-23 19:22:04 UTC) #10
Message was sent while issue was closed.
Landed without the .pdf file.

Note my ~/.subversin/config already has:
*.pdf = svn:mime-type=application/pdf

On Mon, Feb 23, 2015 at 11:16 AM, <jiayl@chromium.org> wrote:

> Reviewers: ,
>
> Message:
> Committed patchset #1 (id:1) manually as r294175 (presubmit successful).
>
> Description:
> Land https://codereview.chromium.org/889083003/ to update libsrtp to
> upstream
> 1.5.0
>
> TBR=juberti@chromium.org
> BUG=328475
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294175
>
> Please review this at https://codereview.chromium.org/936663005/
>
> Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libsrtp/
>
> Affected files (+5449, -1550 lines):
>   M     README.chromium
>   M     config/config.h
>   M     libsrtp.gyp
>   M     srtp/.cvsignore
>   A     srtp/.gitignore
>   M     srtp/CHANGES
>   M     srtp/Makefile
>   M     srtp/Makefile.in
>   M     srtp/README
>   M     srtp/VERSION
>   M     srtp/crypto/Makefile
>   M     srtp/crypto/Makefile.in
>   M     srtp/crypto/ae_xfm/xfm.c
>   M     srtp/crypto/cipher/aes.c
>   M     srtp/crypto/cipher/aes_cbc.c
>   A     srtp/crypto/cipher/aes_gcm_ossl.c
>   M     srtp/crypto/cipher/aes_icm.c
>   A     srtp/crypto/cipher/aes_icm_ossl.c
>   M     srtp/crypto/cipher/cipher.c
>   M     srtp/crypto/cipher/null_cipher.c
>   M     srtp/crypto/hash/auth.c
>   M     srtp/crypto/hash/hmac.c
>   A     srtp/crypto/hash/hmac_ossl.c
>   M     srtp/crypto/hash/null_auth.c
>   M     srtp/crypto/hash/sha1.c
>   M     srtp/crypto/include/aes.h
>   M     srtp/crypto/include/aes_cbc.h
>   A     srtp/crypto/include/aes_gcm_ossl.h
>   M     srtp/crypto/include/aes_icm.h
>   A     srtp/crypto/include/aes_icm_ossl.h
>   M     srtp/crypto/include/cipher.h
>   M     srtp/crypto/include/crypto.h
>   M     srtp/crypto/include/crypto_kernel.h
>   M     srtp/crypto/include/crypto_types.h
>   M     srtp/crypto/include/datatypes.h
>   M     srtp/crypto/include/err.h
>   M     srtp/crypto/include/hmac.h
>   M     srtp/crypto/include/integers.h
>   M     srtp/crypto/include/kernel_compat.h
>   M     srtp/crypto/include/prng.h
>   M     srtp/crypto/include/rdb.h
>   M     srtp/crypto/include/rdbx.h
>   M     srtp/crypto/include/sha1.h
>   M     srtp/crypto/include/xfm.h
>   M     srtp/crypto/kernel/alloc.c
>   M     srtp/crypto/kernel/crypto_kernel.c
>   M     srtp/crypto/kernel/err.c
>   M     srtp/crypto/kernel/key.c
>   M     srtp/crypto/math/datatypes.c
>   M     srtp/crypto/math/gf2_8.c
>   M     srtp/crypto/math/math.c
>   M     srtp/crypto/math/stat.c
>   M     srtp/crypto/replay/rdb.c
>   M     srtp/crypto/replay/rdbx.c
>   M     srtp/crypto/replay/ut_sim.c
>   M     srtp/crypto/rng/ctr_prng.c
>   M     srtp/crypto/rng/prng.c
>   A     srtp/crypto/rng/rand_source_ossl.c
>   M     srtp/crypto/test/aes_calc.c
>   M     srtp/crypto/test/cipher_driver.c
>   M     srtp/crypto/test/datatypes_driver.c
>   M     srtp/crypto/test/env.c
>   M     srtp/crypto/test/kernel_driver.c
>   M     srtp/crypto/test/rand_gen.c
>   A     srtp/crypto/test/rand_gen_soak.c
>   M     srtp/crypto/test/sha1_driver.c
>   M     srtp/crypto/test/stat_driver.c
>   M     srtp/doc/Makefile
>   M     srtp/include/srtp.h
>   M     srtp/include/srtp_priv.h
>   M     srtp/srtp.def
>   M     srtp/srtp/ekt.c
>   M     srtp/srtp/srtp.c
>   M     srtp/tables/aes_tables.c
>   M     srtp/test/lfsr.c
>   M     srtp/test/rdbx_driver.c
>   M     srtp/test/replay_driver.c
>   M     srtp/test/roc_driver.c
>   M     srtp/test/rtp.c
>   A     srtp/test/rtp_decoder.h
>   A     srtp/test/rtp_decoder.c
>   M     srtp/test/rtpw.c
>   M     srtp/test/rtpw_test.sh
>   A     srtp/test/rtpw_test_gcm.sh
>   M     srtp/test/srtp_driver.c
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698