webkit/renderer/compositor_bindings/scrollbar_impl.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/renderer/compositor_bindings/scrollbar_impl.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/renderer/compositor_bindings/scrollbar_impl.h

diff --git a/webkit/renderer/compositor_bindings/scrollbar_impl.h b/webkit/renderer/compositor_bindings/scrollbar_impl.h

index c77ad79c7609cd8d3d6e579ea85ee9033bd73687..5938a7efa02f41d23ffb7efb2b84121d8ba096e1 100644

--- a/webkit/renderer/compositor_bindings/scrollbar_impl.h

+++ b/webkit/renderer/compositor_bindings/scrollbar_impl.h

@@ -35,7 +35,7 @@ class ScrollbarImpl : public cc::Scrollbar {

virtual gfx::Rect TrackRect() const OVERRIDE;

virtual void PaintPart(SkCanvas* canvas,

cc::ScrollbarPart part,

- gfx::Rect content_rect) OVERRIDE;

+ const gfx::Rect& content_rect) OVERRIDE;

private:

scoped_ptr<blink::WebScrollbar> scrollbar_;

« no previous file with comments | « ui/compositor/layer.cc ('k') | webkit/renderer/compositor_bindings/scrollbar_impl.cc » ('j') | no next file with comments »