webkit/renderer/compositor_bindings/scrollbar_impl.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/renderer/compositor_bindings/scrollbar_impl.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/renderer/compositor_bindings/scrollbar_impl.h ('k') | webkit/renderer/compositor_bindings/web_content_layer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/renderer/compositor_bindings/scrollbar_impl.cc

diff --git a/webkit/renderer/compositor_bindings/scrollbar_impl.cc b/webkit/renderer/compositor_bindings/scrollbar_impl.cc

index fb60cd89a5e043450cb80b796de9f8029e342ad8..adbb6b81a5061d4eff414efc1b7e3d592820cdee 100644

--- a/webkit/renderer/compositor_bindings/scrollbar_impl.cc

+++ b/webkit/renderer/compositor_bindings/scrollbar_impl.cc

@@ -63,7 +63,8 @@ gfx::Rect ScrollbarImpl::TrackRect() const {

}

void ScrollbarImpl::PaintPart(

- SkCanvas* canvas, cc::ScrollbarPart part, gfx::Rect content_rect) {

+ SkCanvas* canvas, cc::ScrollbarPart part,

+ const gfx::Rect& content_rect) {

if (part == cc::THUMB) {

painter_.paintThumb(canvas, content_rect);

return;