Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: content/browser/android/in_process/synchronous_compositor_output_surface.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | content/browser/aura/software_output_device_ozone.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/in_process/synchronous_compositor_output_surface.cc
diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
index b7c150f7c292c9f75ec221f3e9aef809789d8ce0..2058fd18a1881eaed54e9f005cf554cf83211b25 100644
--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc
+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
@@ -78,7 +78,7 @@ class SynchronousCompositorOutputSurface::SoftwareDevice
virtual void Resize(gfx::Size size) OVERRIDE {
// Intentional no-op: canvas size is controlled by the embedder.
}
- virtual SkCanvas* BeginPaint(gfx::Rect damage_rect) OVERRIDE {
+ virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect) OVERRIDE {
if (!surface_->current_sw_canvas_) {
NOTREACHED() << "BeginPaint with no canvas set";
return &null_canvas_;
@@ -89,7 +89,7 @@ class SynchronousCompositorOutputSurface::SoftwareDevice
}
virtual void EndPaint(cc::SoftwareFrameData* frame_data) OVERRIDE {
}
- virtual void CopyToBitmap(gfx::Rect rect, SkBitmap* output) OVERRIDE {
+ virtual void CopyToBitmap(const gfx::Rect& rect, SkBitmap* output) OVERRIDE {
NOTIMPLEMENTED();
}
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | content/browser/aura/software_output_device_ozone.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698