Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: cc/trees/thread_proxy.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/thread_proxy.cc
diff --git a/cc/trees/thread_proxy.cc b/cc/trees/thread_proxy.cc
index 0518a6b4440a4c4b1beca46510ef36820d41d376..d8cbfb858be1e045c62a1d234963b5f1c33c19e2 100644
--- a/cc/trees/thread_proxy.cc
+++ b/cc/trees/thread_proxy.cc
@@ -126,7 +126,7 @@ ThreadProxy::~ThreadProxy() {
DCHECK(!started_);
}
-bool ThreadProxy::CompositeAndReadback(void* pixels, gfx::Rect rect) {
+bool ThreadProxy::CompositeAndReadback(void* pixels, const gfx::Rect& rect) {
TRACE_EVENT0("cc", "ThreadProxy::CompositeAndReadback");
DCHECK(IsMainThread());
DCHECK(layer_tree_host());
@@ -507,7 +507,7 @@ void ThreadProxy::SendManagedMemoryStats() {
bool ThreadProxy::IsInsideDraw() { return inside_draw_; }
-void ThreadProxy::SetNeedsRedraw(gfx::Rect damage_rect) {
+void ThreadProxy::SetNeedsRedraw(const gfx::Rect& damage_rect) {
DCHECK(IsMainThread());
TRACE_EVENT0("cc", "ThreadProxy::SetNeedsRedraw");
Proxy::ImplThreadTaskRunner()->PostTask(
@@ -562,7 +562,7 @@ void ThreadProxy::SetNeedsManageTilesOnImplThread() {
scheduler_on_impl_thread_->SetNeedsManageTiles();
}
-void ThreadProxy::SetNeedsRedrawRectOnImplThread(gfx::Rect damage_rect) {
+void ThreadProxy::SetNeedsRedrawRectOnImplThread(const gfx::Rect& damage_rect) {
DCHECK(IsImplThread());
layer_tree_host_impl_->SetViewportDamage(damage_rect);
SetNeedsRedrawOnImplThread();
« no previous file with comments | « cc/trees/thread_proxy.h ('k') | content/browser/android/in_process/synchronous_compositor_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698