Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | cc/trees/layer_tree_host_pixeltest_masks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 6113bd411955d19eb68eff06e979d046807bcee1..ef306423db024bcb26b4359a90e87c5ffe93cfb1 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -117,7 +117,8 @@ class LayerTreeHostImplTest : public testing::Test,
virtual void SetNeedsRedrawOnImplThread() OVERRIDE {
did_request_redraw_ = true;
}
- virtual void SetNeedsRedrawRectOnImplThread(gfx::Rect damage_rect) OVERRIDE {
+ virtual void SetNeedsRedrawRectOnImplThread(
+ const gfx::Rect& damage_rect) OVERRIDE {
did_request_redraw_ = true;
}
virtual void SetNeedsManageTilesOnImplThread() OVERRIDE {
@@ -2786,9 +2787,11 @@ class BlendStateCheckLayer : public LayerImpl {
bool quads_appended() const { return quads_appended_; }
- void SetQuadRect(gfx::Rect rect) { quad_rect_ = rect; }
- void SetQuadVisibleRect(gfx::Rect rect) { quad_visible_rect_ = rect; }
- void SetOpaqueContentRect(gfx::Rect rect) { opaque_content_rect_ = rect; }
+ void SetQuadRect(const gfx::Rect& rect) { quad_rect_ = rect; }
+ void SetQuadVisibleRect(const gfx::Rect& rect) { quad_visible_rect_ = rect; }
+ void SetOpaqueContentRect(const gfx::Rect& rect) {
+ opaque_content_rect_ = rect;
+ }
private:
BlendStateCheckLayer(LayerTreeImpl* tree_impl,
@@ -4814,7 +4817,7 @@ class CountingSoftwareDevice : public SoftwareOutputDevice {
public:
CountingSoftwareDevice() : frames_began_(0), frames_ended_(0) {}
- virtual SkCanvas* BeginPaint(gfx::Rect damage_rect) OVERRIDE {
+ virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect) OVERRIDE {
++frames_began_;
return SoftwareOutputDevice::BeginPaint(damage_rect);
}
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | cc/trees/layer_tree_host_pixeltest_masks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698