Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index f051b335a70ccf4848505efcdc6d8b664c74abee..206e6864c27466f745a872633093e1e57082b288 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -601,7 +601,7 @@ static void AppendQuadsForRenderSurfaceLayer(
static void AppendQuadsToFillScreen(
ResourceProvider::ResourceId overhang_resource_id,
gfx::SizeF overhang_resource_scaled_size,
- gfx::Rect root_scroll_layer_rect,
+ const gfx::Rect& root_scroll_layer_rect,
RenderPass* target_render_pass,
LayerImpl* root_layer,
SkColor screen_background_color,
@@ -960,7 +960,7 @@ void LayerTreeHostImpl::DidAnimateScrollOffset() {
client_->RenewTreePriority();
}
-void LayerTreeHostImpl::SetViewportDamage(gfx::Rect damage_rect) {
+void LayerTreeHostImpl::SetViewportDamage(const gfx::Rect& damage_rect) {
viewport_damage_rect_.Union(damage_rect);
}
@@ -1077,7 +1077,7 @@ void LayerTreeHostImpl::RemoveRenderPasses(RenderPassCuller culler,
}
bool LayerTreeHostImpl::PrepareToDraw(FrameData* frame,
- gfx::Rect device_viewport_damage_rect) {
+ const gfx::Rect& damage_rect) {
TRACE_EVENT1("cc",
"LayerTreeHostImpl::PrepareToDraw",
"SourceFrameNumber",
@@ -1098,6 +1098,7 @@ bool LayerTreeHostImpl::PrepareToDraw(FrameData* frame,
frame->contains_incomplete_tile = false;
frame->has_no_damage = false;
+ gfx::Rect device_viewport_damage_rect(damage_rect);
if (active_tree_->root_layer()) {
device_viewport_damage_rect.Union(viewport_damage_rect_);
viewport_damage_rect_ = gfx::Rect();
@@ -1246,8 +1247,8 @@ void LayerTreeHostImpl::SetManagedMemoryPolicy(
void LayerTreeHostImpl::SetExternalDrawConstraints(
const gfx::Transform& transform,
- gfx::Rect viewport,
- gfx::Rect clip,
+ const gfx::Rect& viewport,
+ const gfx::Rect& clip,
bool valid_for_tile_management) {
external_transform_ = transform;
external_viewport_ = viewport;
@@ -1255,7 +1256,7 @@ void LayerTreeHostImpl::SetExternalDrawConstraints(
device_viewport_valid_for_tile_management_ = valid_for_tile_management;
}
-void LayerTreeHostImpl::SetNeedsRedrawRect(gfx::Rect damage_rect) {
+void LayerTreeHostImpl::SetNeedsRedrawRect(const gfx::Rect& damage_rect) {
if (damage_rect.IsEmpty())
return;
NotifySwapPromiseMonitorsOfSetNeedsRedraw();
@@ -1500,7 +1501,7 @@ void LayerTreeHostImpl::DidLoseOutputSurface() {
}
void LayerTreeHostImpl::Readback(void* pixels,
- gfx::Rect rect_in_device_viewport) {
+ const gfx::Rect& rect_in_device_viewport) {
DCHECK(renderer_);
renderer_->GetFramebufferPixels(pixels, rect_in_device_viewport);
}
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698