cc/test/skia_common.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/skia_common.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/skia_common.h

diff --git a/cc/test/skia_common.h b/cc/test/skia_common.h

index 853fb5da78243a3e49be94a4176a7eb6b9aaeed6..0d3833ec53de50fac704ae9cb94dc1e6db2ec781 100644

--- a/cc/test/skia_common.h

+++ b/cc/test/skia_common.h

@@ -35,7 +35,7 @@ class TestPixelRef : public SkPixelRef {

};

void DrawPicture(unsigned char* buffer,

- gfx::Rect layer_rect,

+ const gfx::Rect& layer_rect,

scoped_refptr<Picture> picture);

void CreateBitmap(gfx::Size size, const char* uri, SkBitmap* bitmap);

« no previous file with comments | « cc/test/render_pass_test_utils.cc ('k') | cc/test/skia_common.cc » ('j') | no next file with comments »