cc/test/skia_common.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/skia_common.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/skia_common.cc

diff --git a/cc/test/skia_common.cc b/cc/test/skia_common.cc

index de2733d77ded1d5bc48da57464cd3b4d2d50f994..27cc3c6ef4d9a68a200b3bb20687cb8be85aef2b 100644

--- a/cc/test/skia_common.cc

+++ b/cc/test/skia_common.cc

@@ -32,7 +32,7 @@ SkPixelRef* TestPixelRef::deepCopy(

void DrawPicture(unsigned char* buffer,

- gfx::Rect layer_rect,

+ const gfx::Rect& layer_rect,

scoped_refptr<Picture> picture) {

SkBitmap bitmap;

bitmap.setConfig(SkBitmap::kARGB_8888_Config,

« no previous file with comments | « cc/test/skia_common.h ('k') | cc/test/solid_color_content_layer_client.h » ('j') | no next file with comments »