Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: cc/test/render_pass_test_utils.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/render_pass_test_utils.h ('k') | cc/test/skia_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/render_pass_test_utils.cc
diff --git a/cc/test/render_pass_test_utils.cc b/cc/test/render_pass_test_utils.cc
index 32e6f48cb409821cdc4b040b25bbe106fe5aeb5a..8b018cf8805ef23d23668e7c844c71afc5126469 100644
--- a/cc/test/render_pass_test_utils.cc
+++ b/cc/test/render_pass_test_utils.cc
@@ -20,7 +20,7 @@ namespace cc {
TestRenderPass* AddRenderPass(RenderPassList* pass_list,
RenderPass::Id id,
- gfx::Rect output_rect,
+ const gfx::Rect& output_rect,
const gfx::Transform& root_transform) {
scoped_ptr<TestRenderPass> pass(TestRenderPass::Create());
pass->SetNew(id, output_rect, output_rect, root_transform);
@@ -30,7 +30,7 @@ TestRenderPass* AddRenderPass(RenderPassList* pass_list,
}
SolidColorDrawQuad* AddQuad(TestRenderPass* pass,
- gfx::Rect rect,
+ const gfx::Rect& rect,
SkColor color) {
MockQuadCuller quad_sink(&pass->quad_list, &pass->shared_quad_state_list);
AppendQuadsData data(pass->id);
@@ -51,7 +51,7 @@ SolidColorDrawQuad* AddQuad(TestRenderPass* pass,
}
SolidColorDrawQuad* AddClippedQuad(TestRenderPass* pass,
- gfx::Rect rect,
+ const gfx::Rect& rect,
SkColor color) {
MockQuadCuller quad_sink(&pass->quad_list, &pass->shared_quad_state_list);
AppendQuadsData data(pass->id);
@@ -72,7 +72,7 @@ SolidColorDrawQuad* AddClippedQuad(TestRenderPass* pass,
}
SolidColorDrawQuad* AddTransformedQuad(TestRenderPass* pass,
- gfx::Rect rect,
+ const gfx::Rect& rect,
SkColor color,
const gfx::Transform& transform) {
MockQuadCuller quad_sink(&pass->quad_list, &pass->shared_quad_state_list);
« no previous file with comments | « cc/test/render_pass_test_utils.h ('k') | cc/test/skia_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698