cc/test/layer_tree_pixel_test.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/layer_tree_pixel_test.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/layer_tree_pixel_test.h

diff --git a/cc/test/layer_tree_pixel_test.h b/cc/test/layer_tree_pixel_test.h

index d905d539606a7df0ed7697d247516bb174ce96bd..a72f1db2d82825dd7888a6656f05a2e4ed584c6e 100644

--- a/cc/test/layer_tree_pixel_test.h

+++ b/cc/test/layer_tree_pixel_test.h

@@ -48,14 +48,14 @@ class LayerTreePixelTest : public LayerTreeTest {

void TryEndTest();

- scoped_refptr<SolidColorLayer> CreateSolidColorLayer(gfx::Rect rect,

+ scoped_refptr<SolidColorLayer> CreateSolidColorLayer(const gfx::Rect& rect,

SkColor color);

scoped_refptr<SolidColorLayer> CreateSolidColorLayerWithBorder(

- gfx::Rect rect,

+ const gfx::Rect& rect,

SkColor color,

int border_width,

SkColor border_color);

- scoped_refptr<TextureLayer> CreateTextureLayer(gfx::Rect rect,

+ scoped_refptr<TextureLayer> CreateTextureLayer(const gfx::Rect& rect,

const SkBitmap& bitmap);

enum PixelTestType {

« no previous file with comments | « cc/test/layer_test_common.cc ('k') | cc/test/layer_tree_pixel_test.cc » ('j') | no next file with comments »