Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: cc/test/layer_tree_pixel_test.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_tree_pixel_test.h ('k') | cc/test/layer_tree_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_tree_pixel_test.cc
diff --git a/cc/test/layer_tree_pixel_test.cc b/cc/test/layer_tree_pixel_test.cc
index d0635a7bf3d47827828968cecab0b241628a24de..fb54ce276f0c43e0d8f027755f7605cfee7a7501 100644
--- a/cc/test/layer_tree_pixel_test.cc
+++ b/cc/test/layer_tree_pixel_test.cc
@@ -119,7 +119,7 @@ void LayerTreePixelTest::AfterTest() {
}
scoped_refptr<SolidColorLayer> LayerTreePixelTest::CreateSolidColorLayer(
- gfx::Rect rect, SkColor color) {
+ const gfx::Rect& rect, SkColor color) {
scoped_refptr<SolidColorLayer> layer = SolidColorLayer::Create();
layer->SetIsDrawable(true);
layer->SetAnchorPoint(gfx::PointF());
@@ -150,7 +150,8 @@ void LayerTreePixelTest::TryEndTest() {
scoped_refptr<SolidColorLayer> LayerTreePixelTest::
CreateSolidColorLayerWithBorder(
- gfx::Rect rect, SkColor color, int border_width, SkColor border_color) {
+ const gfx::Rect& rect, SkColor color,
+ int border_width, SkColor border_color) {
scoped_refptr<SolidColorLayer> layer = CreateSolidColorLayer(rect, color);
scoped_refptr<SolidColorLayer> border_top = CreateSolidColorLayer(
gfx::Rect(0, 0, rect.width(), border_width), border_color);
@@ -177,7 +178,7 @@ scoped_refptr<SolidColorLayer> LayerTreePixelTest::
}
scoped_refptr<TextureLayer> LayerTreePixelTest::CreateTextureLayer(
- gfx::Rect rect, const SkBitmap& bitmap) {
+ const gfx::Rect& rect, const SkBitmap& bitmap) {
scoped_refptr<TextureLayer> layer = TextureLayer::CreateForMailbox(NULL);
layer->SetIsDrawable(true);
layer->SetAnchorPoint(gfx::PointF());
« no previous file with comments | « cc/test/layer_tree_pixel_test.h ('k') | cc/test/layer_tree_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698