Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: cc/test/layer_test_common.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_test_common.h ('k') | cc/test/layer_tree_pixel_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_test_common.cc
diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc
index 3ccd0a43a372f7219a030b680827ea4896dab7b7..0171999ae5255d9692ece5e61d0ab252c23ea276 100644
--- a/cc/test/layer_test_common.cc
+++ b/cc/test/layer_test_common.cc
@@ -19,7 +19,7 @@ namespace cc {
// Align with expected and actual output.
const char* LayerTestCommon::quad_string = " Quad: ";
-static bool CanRectFBeSafelyRoundedToRect(gfx::RectF r) {
+static bool CanRectFBeSafelyRoundedToRect(const gfx::RectF& r) {
// Ensure that range of float values is not beyond integer range.
if (!r.IsExpressibleAsRect())
return false;
@@ -33,7 +33,7 @@ static bool CanRectFBeSafelyRoundedToRect(gfx::RectF r) {
}
void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads,
- gfx::Rect rect) {
+ const gfx::Rect& rect) {
Region remaining = rect;
for (size_t i = 0; i < quads.size(); ++i) {
« no previous file with comments | « cc/test/layer_test_common.h ('k') | cc/test/layer_tree_pixel_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698