Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: cc/scheduler/texture_uploader.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | cc/scheduler/texture_uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/texture_uploader.h
diff --git a/cc/scheduler/texture_uploader.h b/cc/scheduler/texture_uploader.h
index 815282e2c4b6372b22322cf74aedff5ddf0d415f..362f00199da8244f550f629296de90f63cdf1108 100644
--- a/cc/scheduler/texture_uploader.h
+++ b/cc/scheduler/texture_uploader.h
@@ -43,8 +43,8 @@ class CC_EXPORT TextureUploader {
// image be a buffer for content_rect. This function will copy the region
// corresponding to source_rect to dest_offset in this sub-image.
void Upload(const uint8* image,
- gfx::Rect content_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& content_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format,
gfx::Size size);
@@ -92,13 +92,13 @@ class CC_EXPORT TextureUploader {
void ProcessQueries();
void UploadWithTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& image_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format);
void UploadWithMapTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& image_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format);
void UploadWithTexImageETC1(const uint8* image, gfx::Size size);
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | cc/scheduler/texture_uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698