Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: cc/scheduler/texture_uploader.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/test/fake_content_layer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/texture_uploader.cc
diff --git a/cc/scheduler/texture_uploader.cc b/cc/scheduler/texture_uploader.cc
index 6758f11de2d788c22acc380f4afefd06df4d2507..e194ede6b74edfac19373e59a06bb043e2372ef1 100644
--- a/cc/scheduler/texture_uploader.cc
+++ b/cc/scheduler/texture_uploader.cc
@@ -129,8 +129,8 @@ void TextureUploader::EndQuery() {
}
void TextureUploader::Upload(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& image_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format,
gfx::Size size) {
@@ -173,8 +173,8 @@ void TextureUploader::ReleaseCachedQueries() {
}
void TextureUploader::UploadWithTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& image_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format) {
TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage");
@@ -227,8 +227,8 @@ void TextureUploader::UploadWithTexSubImage(const uint8* image,
}
void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
+ const gfx::Rect& image_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
ResourceFormat format) {
TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage");
« no previous file with comments | « cc/scheduler/texture_uploader.h ('k') | cc/test/fake_content_layer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698