Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3475)

Unified Diff: cc/resources/picture_pile_impl.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture_pile_base.cc ('k') | cc/resources/picture_pile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture_pile_impl.h
diff --git a/cc/resources/picture_pile_impl.h b/cc/resources/picture_pile_impl.h
index 2bc9da80bd757b52b4b353d9fb52facedb2a1d8b..54a69880d2e1ba422bd20da250720b5375aa4727 100644
--- a/cc/resources/picture_pile_impl.h
+++ b/cc/resources/picture_pile_impl.h
@@ -39,7 +39,7 @@ class CC_EXPORT PicturePileImpl : public PicturePileBase {
// measured value over all runs.
void RasterDirect(
SkCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* rendering_stats_instrumentation);
@@ -48,7 +48,7 @@ class CC_EXPORT PicturePileImpl : public PicturePileBase {
// that itself will then be blended and thus that a canvas clear is required.
void RasterToBitmap(
SkCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* stats_instrumentation);
@@ -56,7 +56,7 @@ class CC_EXPORT PicturePileImpl : public PicturePileBase {
// SkDrawPictureCallback, which allows us to early out from analysis.
void RasterForAnalysis(
skia::AnalysisCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* stats_instrumentation);
@@ -71,18 +71,18 @@ class CC_EXPORT PicturePileImpl : public PicturePileBase {
SkColor solid_color;
};
- void AnalyzeInRect(gfx::Rect content_rect,
+ void AnalyzeInRect(const gfx::Rect& content_rect,
float contents_scale,
Analysis* analysis);
- void AnalyzeInRect(gfx::Rect content_rect,
+ void AnalyzeInRect(const gfx::Rect& content_rect,
float contents_scale,
Analysis* analysis,
RenderingStatsInstrumentation* stats_instrumentation);
class CC_EXPORT PixelRefIterator {
public:
- PixelRefIterator(gfx::Rect content_rect,
+ PixelRefIterator(const gfx::Rect& content_rect,
float contents_scale,
const PicturePileImpl* picture_pile);
~PixelRefIterator();
@@ -129,15 +129,15 @@ class CC_EXPORT PicturePileImpl : public PicturePileBase {
private:
typedef std::map<Picture*, Region> PictureRegionMap;
- void CoalesceRasters(gfx::Rect canvas_rect,
- gfx::Rect content_rect,
+ void CoalesceRasters(const gfx::Rect& canvas_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
PictureRegionMap* result);
void RasterCommon(
SkCanvas* canvas,
SkDrawPictureCallback* callback,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* rendering_stats_instrumentation,
bool is_analysis);
« no previous file with comments | « cc/resources/picture_pile_base.cc ('k') | cc/resources/picture_pile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698