Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: cc/resources/picture_pile_impl.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture_pile_impl.h ('k') | cc/resources/prioritized_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture_pile_impl.cc
diff --git a/cc/resources/picture_pile_impl.cc b/cc/resources/picture_pile_impl.cc
index b6f4d77156f57c8d94ffdd377c948e97674cf37a..e5531686df6f19418809f6837922322655a7dd28 100644
--- a/cc/resources/picture_pile_impl.cc
+++ b/cc/resources/picture_pile_impl.cc
@@ -70,7 +70,7 @@ PicturePileImpl* PicturePileImpl::GetCloneForDrawingOnThread(
void PicturePileImpl::RasterDirect(
SkCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* rendering_stats_instrumentation) {
RasterCommon(canvas,
@@ -83,7 +83,7 @@ void PicturePileImpl::RasterDirect(
void PicturePileImpl::RasterForAnalysis(
skia::AnalysisCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* stats_instrumentation) {
RasterCommon(
@@ -92,7 +92,7 @@ void PicturePileImpl::RasterForAnalysis(
void PicturePileImpl::RasterToBitmap(
SkCanvas* canvas,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* rendering_stats_instrumentation) {
if (clear_canvas_with_debug_color_) {
@@ -145,8 +145,8 @@ void PicturePileImpl::RasterToBitmap(
false);
}
-void PicturePileImpl::CoalesceRasters(gfx::Rect canvas_rect,
- gfx::Rect content_rect,
+void PicturePileImpl::CoalesceRasters(const gfx::Rect& canvas_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
PictureRegionMap* results) {
DCHECK(results);
@@ -207,7 +207,7 @@ void PicturePileImpl::CoalesceRasters(gfx::Rect canvas_rect,
void PicturePileImpl::RasterCommon(
SkCanvas* canvas,
SkDrawPictureCallback* callback,
- gfx::Rect canvas_rect,
+ const gfx::Rect& canvas_rect,
float contents_scale,
RenderingStatsInstrumentation* rendering_stats_instrumentation,
bool is_analysis) {
@@ -309,14 +309,14 @@ skia::RefPtr<SkPicture> PicturePileImpl::GetFlattenedPicture() {
}
void PicturePileImpl::AnalyzeInRect(
- gfx::Rect content_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
PicturePileImpl::Analysis* analysis) {
AnalyzeInRect(content_rect, contents_scale, analysis, NULL);
}
void PicturePileImpl::AnalyzeInRect(
- gfx::Rect content_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
PicturePileImpl::Analysis* analysis,
RenderingStatsInstrumentation* stats_instrumentation) {
@@ -350,7 +350,7 @@ PicturePileImpl::Analysis::~Analysis() {
}
PicturePileImpl::PixelRefIterator::PixelRefIterator(
- gfx::Rect content_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
const PicturePileImpl* picture_pile)
: picture_pile_(picture_pile),
« no previous file with comments | « cc/resources/picture_pile_impl.h ('k') | cc/resources/prioritized_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698