cc/quads/render_pass.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/render_pass.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/render_pass.h

diff --git a/cc/quads/render_pass.h b/cc/quads/render_pass.h

index 407381fb1727fc379c009809b201927b5fe246c2..4285e53010311d27d7b4fd58ddb70f81b15354c0 100644

--- a/cc/quads/render_pass.h

+++ b/cc/quads/render_pass.h

@@ -76,13 +76,13 @@ class CC_EXPORT RenderPass {

ScopedPtrVector<RenderPass>* out);

void SetNew(Id id,

- gfx::Rect output_rect,

- gfx::RectF damage_rect,

+ const gfx::Rect& output_rect,

+ const gfx::RectF& damage_rect,

const gfx::Transform& transform_to_root_target);

void SetAll(Id id,

- gfx::Rect output_rect,

- gfx::RectF damage_rect,

+ const gfx::Rect& output_rect,

+ const gfx::RectF& damage_rect,

const gfx::Transform& transform_to_root_target,

bool has_transparent_background);

« no previous file with comments | « cc/quads/picture_draw_quad.cc ('k') | cc/quads/render_pass.cc » ('j') | no next file with comments »