Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: cc/quads/picture_draw_quad.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/picture_draw_quad.h ('k') | cc/quads/render_pass.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/picture_draw_quad.cc
diff --git a/cc/quads/picture_draw_quad.cc b/cc/quads/picture_draw_quad.cc
index bdb12e64d7a75dda1f01fb4753a7bc2a82fa88ba..f51b65b5aa9a1260451fddfea4f1aafbdb99339a 100644
--- a/cc/quads/picture_draw_quad.cc
+++ b/cc/quads/picture_draw_quad.cc
@@ -21,12 +21,12 @@ scoped_ptr<PictureDrawQuad> PictureDrawQuad::Create() {
}
void PictureDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
- gfx::Rect rect,
- gfx::Rect opaque_rect,
+ const gfx::Rect& rect,
+ const gfx::Rect& opaque_rect,
const gfx::RectF& tex_coord_rect,
gfx::Size texture_size,
ResourceFormat texture_format,
- gfx::Rect content_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
scoped_refptr<PicturePileImpl> picture_pile) {
ContentDrawQuadBase::SetNew(shared_quad_state,
@@ -44,14 +44,14 @@ void PictureDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
}
void PictureDrawQuad::SetAll(const SharedQuadState* shared_quad_state,
- gfx::Rect rect,
- gfx::Rect opaque_rect,
- gfx::Rect visible_rect,
+ const gfx::Rect& rect,
+ const gfx::Rect& opaque_rect,
+ const gfx::Rect& visible_rect,
bool needs_blending,
const gfx::RectF& tex_coord_rect,
gfx::Size texture_size,
ResourceFormat texture_format,
- gfx::Rect content_rect,
+ const gfx::Rect& content_rect,
float contents_scale,
scoped_refptr<PicturePileImpl> picture_pile) {
ContentDrawQuadBase::SetAll(shared_quad_state,
« no previous file with comments | « cc/quads/picture_draw_quad.h ('k') | cc/quads/render_pass.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698