cc/output/gl_renderer_unittest.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/gl_renderer_unittest.cc

diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc

index b7f5c801938ae9616831126358d98bc9fe32b8c7..c4f2e324d727764dc9132bcde99b2c554f49c1f0 100644

--- a/cc/output/gl_renderer_unittest.cc

+++ b/cc/output/gl_renderer_unittest.cc

@@ -1751,7 +1751,8 @@ class MockOutputSurfaceTest : public GLRendererTest {

void SwapBuffers() { renderer_->SwapBuffers(CompositorFrameMetadata()); }

- void DrawFrame(float device_scale_factor, gfx::Rect device_viewport_rect) {

+ void DrawFrame(float device_scale_factor,

+ const gfx::Rect& device_viewport_rect) {

RenderPass::Id render_pass_id(1, 0);

TestRenderPass* render_pass = AddRenderPass(&render_passes_in_draw_order_,

render_pass_id,

« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/output_surface.h » ('j') | no next file with comments »