cc/output/output_surface.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/output_surface.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/output_surface.h

diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h

index 0d7d4e7fb964ab9647bf8804e9bb402f097d1516..aae3b8c12ebfe5c7c985955df1b5462226dd4d33 100644

--- a/cc/output/output_surface.h

+++ b/cc/output/output_surface.h

@@ -175,7 +175,7 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient {

// Forwarded to OutputSurfaceClient but threaded through OutputSurface

// first so OutputSurface has a chance to update the FrameRateController

- void SetNeedsRedrawRect(gfx::Rect damage_rect);

+ void SetNeedsRedrawRect(const gfx::Rect& damage_rect);

void BeginImplFrame(const BeginFrameArgs& args);

void DidSwapBuffers();

void OnSwapBuffersComplete();

@@ -183,8 +183,8 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient {

void DidLoseOutputSurface();

void SetExternalStencilTest(bool enabled);

void SetExternalDrawConstraints(const gfx::Transform& transform,

- gfx::Rect viewport,

- gfx::Rect clip,

+ const gfx::Rect& viewport,

+ const gfx::Rect& clip,

bool valid_for_tile_management);

// virtual for testing.

« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/output_surface.cc » ('j') | no next file with comments »