cc/layers/render_surface_impl.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/render_surface_impl.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/render_surface_impl.h

diff --git a/cc/layers/render_surface_impl.h b/cc/layers/render_surface_impl.h

index c02a3194098027d74bda654561bff1550657ad91..7207dc0676767ccff0a001b34ebed85d3372f0bf 100644

--- a/cc/layers/render_surface_impl.h

+++ b/cc/layers/render_surface_impl.h

@@ -101,7 +101,7 @@ class CC_EXPORT RenderSurfaceImpl {

void SetIsClipped(bool is_clipped) { is_clipped_ = is_clipped; }

bool is_clipped() const { return is_clipped_; }

- void SetClipRect(gfx::Rect clip_rect);

+ void SetClipRect(const gfx::Rect& clip_rect);

gfx::Rect clip_rect() const { return clip_rect_; }

// When false, the RenderSurface does not contribute to another target

@@ -117,7 +117,7 @@ class CC_EXPORT RenderSurfaceImpl {

bool ContentsChanged() const;

- void SetContentRect(gfx::Rect content_rect);

+ void SetContentRect(const gfx::Rect& content_rect);

gfx::Rect content_rect() const { return content_rect_; }

LayerImplList& layer_list() { return layer_list_; }

« no previous file with comments | « cc/layers/render_surface.h ('k') | cc/layers/render_surface_impl.cc » ('j') | no next file with comments »