Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: cc/debug/overdraw_metrics.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/debug_rect_history.h ('k') | cc/debug/overdraw_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/overdraw_metrics.h
diff --git a/cc/debug/overdraw_metrics.h b/cc/debug/overdraw_metrics.h
index 43bd19baa73e19d46457e59d0b4ada99048fa81b..c53b2aa3cffb82f8500566f6b4befd852eaa0e26 100644
--- a/cc/debug/overdraw_metrics.h
+++ b/cc/debug/overdraw_metrics.h
@@ -27,15 +27,15 @@ class OverdrawMetrics {
// Record pixels painted by WebKit into the texture updater, but does not mean
// the pixels were rasterized in main memory.
- void DidPaint(gfx::Rect painted_rect);
+ void DidPaint(const gfx::Rect& painted_rect);
// Records that an invalid tile was culled and did not need to be
// painted/uploaded, and did not contribute to other tiles needing to be
// painted.
void DidCullTilesForUpload(int count);
// Records pixels that were uploaded to texture memory.
void DidUpload(const gfx::Transform& transform_to_target,
- gfx::Rect upload_rect,
- gfx::Rect opaque_rect);
+ const gfx::Rect& upload_rect,
+ const gfx::Rect& opaque_rect);
// Record contents texture(s) behind present using the given number of bytes.
void DidUseContentsTextureMemoryBytes(size_t contents_texture_use_bytes);
// Record RenderSurfaceImpl texture(s) being present using the given number of
@@ -46,12 +46,12 @@ class OverdrawMetrics {
// Record pixels that were not drawn to screen.
void DidCullForDrawing(const gfx::Transform& transform_to_target,
- gfx::Rect before_cull_rect,
- gfx::Rect after_cull_rect);
+ const gfx::Rect& before_cull_rect,
+ const gfx::Rect& after_cull_rect);
// Record pixels that were drawn to screen.
void DidDraw(const gfx::Transform& transform_to_target,
- gfx::Rect after_cull_rect,
- gfx::Rect opaque_rect);
+ const gfx::Rect& after_cull_rect,
+ const gfx::Rect& opaque_rect);
void RecordMetrics(const LayerTreeHost* layer_tree_host) const;
void RecordMetrics(const LayerTreeHostImpl* layer_tree_host_impl) const;
« no previous file with comments | « cc/debug/debug_rect_history.h ('k') | cc/debug/overdraw_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698