Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: cc/debug/overdraw_metrics.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/overdraw_metrics.h ('k') | cc/input/scrollbar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/overdraw_metrics.cc
diff --git a/cc/debug/overdraw_metrics.cc b/cc/debug/overdraw_metrics.cc
index a14284d800de785844271be79d9b57317eabb877..f707db0cba81b7064163e6225aeb96af5fb341fa 100644
--- a/cc/debug/overdraw_metrics.cc
+++ b/cc/debug/overdraw_metrics.cc
@@ -55,7 +55,7 @@ static inline float AreaOfMappedQuad(const gfx::Transform& transform,
return PolygonArea(clipped_quad, num_vertices_in_clipped_quad);
}
-void OverdrawMetrics::DidPaint(gfx::Rect painted_rect) {
+void OverdrawMetrics::DidPaint(const gfx::Rect& painted_rect) {
if (!record_metrics_for_frame_)
return;
@@ -69,8 +69,8 @@ void OverdrawMetrics::DidCullTilesForUpload(int count) {
}
void OverdrawMetrics::DidUpload(const gfx::Transform& transform_to_target,
- gfx::Rect upload_rect,
- gfx::Rect opaque_rect) {
+ const gfx::Rect& upload_rect,
+ const gfx::Rect& opaque_rect) {
if (!record_metrics_for_frame_)
return;
@@ -103,8 +103,8 @@ void OverdrawMetrics::DidUseRenderSurfaceTextureMemoryBytes(
void OverdrawMetrics::DidCullForDrawing(
const gfx::Transform& transform_to_target,
- gfx::Rect before_cull_rect,
- gfx::Rect after_cull_rect) {
+ const gfx::Rect& before_cull_rect,
+ const gfx::Rect& after_cull_rect) {
if (!record_metrics_for_frame_)
return;
@@ -117,8 +117,8 @@ void OverdrawMetrics::DidCullForDrawing(
}
void OverdrawMetrics::DidDraw(const gfx::Transform& transform_to_target,
- gfx::Rect after_cull_rect,
- gfx::Rect opaque_rect) {
+ const gfx::Rect& after_cull_rect,
+ const gfx::Rect& opaque_rect) {
if (!record_metrics_for_frame_)
return;
« no previous file with comments | « cc/debug/overdraw_metrics.h ('k') | cc/input/scrollbar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698