Allow extensions of the ManifestParser outside of the content/ layer.

content/public/renderer/content_renderer_client.h

Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index 0744f627ae2332aa21f493627549f4efbd4095a2..7b61be13e3348c7d8136ea36dbf8e5008dd4ecc4 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -61,6 +61,7 @@ struct KeySystemInfo;
 namespace content {
 class BrowserPluginDelegate;
 class DocumentState;
+class ManifestParser;
 class RenderFrame;
 class RenderView;
 class SynchronousCompositor;
@@ -294,6 +295,11 @@ class CONTENT_EXPORT ContentRendererClient {
   // Returns a user agent override specific for |url|, or empty string if
   // default user agent should be used.
   virtual std::string GetUserAgentOverrideForURL(const GURL& url);
+
+  // TODO:
+  virtual bool ParseManifestProperty(const std::string& key,
+                                     const base::Value& value
+                                     /* TODO: errors */);

[Avi (use Gerrit), 2015/02/23 17:30:25]

The ContentRendererClient is a singleton, and thus stateless. Any context that a
function here would need has to be passed in, but I'm not sure how you're
intending this to work. The implementer of this function is getting a key and a
value, but what is it supposed to do with it? It wouldn't even know what
document it belonged to.

I thought that perhaps it would be parsed and the function would return some
chunk of data that content would hold onto, but it returns just a bool. And the
implementation you have in the ChromeContentRenderClient:

//*parser = new ChromeManifestParser();

leads me to think that you're not entirely sure how this is going to work,
either.

 };
 
 }  // namespace content