Allow extensions of the ManifestParser outside of the content/ layer.

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 43 matching lines @@
 
 namespace media {
 class MediaLog;
 class RendererFactory;
 struct KeySystemInfo;
 }
 
 namespace content {
 class BrowserPluginDelegate;
 class DocumentState;
+class ManifestParser;
 class RenderFrame;
 class RenderView;
 class SynchronousCompositor;
 struct WebPluginInfo;
 
 // Embedder API for participating in renderer logic.
 class CONTENT_EXPORT ContentRendererClient {
  public:
   virtual ~ContentRendererClient() {}
 
@@ skipping 213 matching lines @@
 
   // Returns true if the page at |url| can use Pepper Compositor APIs.
   virtual bool IsPluginAllowedToUseCompositorAPI(const GURL& url);
 
   // Returns true if dev channel APIs are available for plugins.
   virtual bool IsPluginAllowedToUseDevChannelAPIs();
 
   // Returns a user agent override specific for |url|, or empty string if
   // default user agent should be used.
   virtual std::string GetUserAgentOverrideForURL(const GURL& url);
+
+  // TODO:
+  virtual bool ParseManifestProperty(const std::string& key,
+                                     const base::Value& value
+                                     /* TODO: errors */);

[Avi (use Gerrit), 2015/02/23 17:30:25]

The ContentRendererClient is a singleton, and thus stateless. Any context that a
function here would need has to be passed in, but I'm not sure how you're
intending this to work. The implementer of this function is getting a key and a
value, but what is it supposed to do with it? It wouldn't even know what
document it belonged to.

I thought that perhaps it would be parsed and the function would return some
chunk of data that content would hold onto, but it returns just a bool. And the
implementation you have in the ChromeContentRenderClient:

//*parser = new ChromeManifestParser();

leads me to think that you're not entirely sure how this is going to work,
either.

 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_