Issue 936403002: PDF: why do we have flags no one uses (or can use)?

Issue 936403002: PDF: why do we have flags no one uses (or can use)? (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
hal.canary, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

PDF: why do we have flags no one uses (or can use)? BUG=skia: Committed: https://skia.googlesource.com/skia/+/cabc08c4296e1ce6c6d9d84cf702361cf439c1bc

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -137 lines)			Patch
M	src/pdf/SkPDFBitmap.cpp	View		5 chunks	+11 lines, -24 lines	0 comments	Download
M	src/pdf/SkPDFCatalog.h	View		3 chunks	+1 line, -7 lines	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFDocument.h	View	1	1 chunk	+1 line, -12 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View		3 chunks	+3 lines, -11 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View		2 chunks	+12 lines, -21 lines	0 comments	Download
M	tests/AnnotationTest.cpp	View		2 chunks	+7 lines, -18 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View		7 chunks	+15 lines, -30 lines	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936403002/20001

5 years, 10 months ago (2015-02-19 15:45:06 UTC) #7

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 16:29:27 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cabc08c4296e1ce6c6d9d84cf702361cf439c1bc