PDF: why do we have flags no one uses (or can use)?

src/pdf/SkPDFBitmap.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkColorPriv.h"
 #include "SkDeflateWStream.h"
 #include "SkPDFBitmap.h"
@@ skipping 12 matching lines @@
 
 static void pdf_stream_end(SkWStream* stream) {
     static const char streamEnd[] = "\nendstream";
     stream->write(streamEnd, strlen(streamEnd));
 }
 
 static size_t pixel_count(const SkBitmap& bm) {
     return SkToSizeT(bm.width()) * SkToSizeT(bm.height());
 }
 
-static bool skip_compression(SkPDFDocument::Flags flag) {
-#ifndef SK_NO_FLATE
-    return SkToBool(flag & SkPDFDocument::kFavorSpeedOverSize_Flags);
-#else
-    return true;
-#endif  // SK_NO_FLATE
-}
-
 // write a single byte to a stream n times.
 static void fill_stream(SkWStream* out, char value, size_t n) {
     char buffer[4096];
     memset(buffer, value, sizeof(buffer));
     while (n) {
         size_t k = SkTMin(n, sizeof(buffer));
         out->write(buffer, k);
         n -= k;
     }
 }
@@ skipping 106 matching lines @@
     void addResources(SkTSet<SkPDFObject*>*, SkPDFCatalog*) const SK_OVERRIDE {}
 
 private:
     const SkBitmap fBitmap;
     void emitDict(SkWStream*, SkPDFCatalog*, size_t, bool) const;
 };
 
 void PDFAlphaBitmap::emitObject(SkWStream* stream, SkPDFCatalog* catalog) {
     SkAutoLockPixels autoLockPixels(fBitmap);
 
-    if (skip_compression(catalog->getDocumentFlags())) {
-        this->emitDict(stream, catalog, pixel_count(fBitmap),
-                       /*deflate=*/false);
-        pdf_stream_begin(stream);
-        pmcolor_alpha_to_a8(fBitmap, stream);
-        pdf_stream_end(stream);
-        return;
-    }
 #ifndef SK_NO_FLATE
     // Write to a temporary buffer to get the compressed length.
     SkDynamicMemoryWStream buffer;
     SkDeflateWStream deflateWStream(&buffer);
     pmcolor_alpha_to_a8(fBitmap, &deflateWStream);
     deflateWStream.finalize();  // call before detachAsStream().
     SkAutoTDelete<SkStreamAsset> asset(buffer.detachAsStream());
 
     this->emitDict(stream, catalog, asset->getLength(), /*deflate=*/true);
     pdf_stream_begin(stream);
     stream->writeStream(asset.get(), asset->getLength());
     pdf_stream_end(stream);
+#else
+    this->emitDict(stream, catalog, pixel_count(fBitmap), /*deflate=*/false);
+    pdf_stream_begin(stream);
+    pmcolor_alpha_to_a8(fBitmap, stream);
+    pdf_stream_end(stream);
 #endif  // SK_NO_FLATE
 }
 
 void PDFAlphaBitmap::emitDict(SkWStream* stream,
                               SkPDFCatalog* catalog,
                               size_t length,
                               bool deflate) const {
     SkPDFDict pdfDict("XObject");
     pdfDict.insertName("Subtype", "Image");
     pdfDict.insertInt("Width", fBitmap.width());
@@ skipping 13 matching lines @@
 void SkPDFBitmap::addResources(SkTSet<SkPDFObject*>* resourceSet,
                                SkPDFCatalog* catalog) const {
     if (fSMask.get()) {
         resourceSet->add(fSMask.get());
     }
 }
 
 void SkPDFBitmap::emitObject(SkWStream* stream, SkPDFCatalog* catalog) {
     SkAutoLockPixels autoLockPixels(fBitmap);
 
-    if (skip_compression(catalog->getDocumentFlags())) {
-        this->emitDict(stream, catalog, 3 * pixel_count(fBitmap),
-                       /*deflate=*/false);
-        pdf_stream_begin(stream);
-        pmcolor_to_rgb24(fBitmap, stream);
-        pdf_stream_end(stream);
-        return;
-    }
 #ifndef SK_NO_FLATE
     // Write to a temporary buffer to get the compressed length.
     SkDynamicMemoryWStream buffer;
     SkDeflateWStream deflateWStream(&buffer);
     pmcolor_to_rgb24(fBitmap, &deflateWStream);
     deflateWStream.finalize();  // call before detachAsStream().
     SkAutoTDelete<SkStreamAsset> asset(buffer.detachAsStream());
 
     this->emitDict(stream, catalog, asset->getLength(), /*deflate=*/true);
     pdf_stream_begin(stream);
     stream->writeStream(asset.get(), asset->getLength());
     pdf_stream_end(stream);
+#else
+    this->emitDict(stream, catalog, 3 * pixel_count(fBitmap), /*deflate=*/false);
+    pdf_stream_begin(stream);
+    pmcolor_to_rgb24(fBitmap, stream);
+    pdf_stream_end(stream);
+    return;
 #endif  // SK_NO_FLATE
 }
 
 void SkPDFBitmap::emitDict(SkWStream* stream,
                            SkPDFCatalog* catalog,
                            size_t length,
                            bool deflate) const {
     SkPDFDict pdfDict("XObject");
     pdfDict.insertName("Subtype", "Image");
     pdfDict.insertInt("Width", fBitmap.width());
@@ skipping 74 matching lines @@
             return NULL;
         }
         // PDFAlphaBitmaps do not get directly canonicalized (they
         // are refed by the SkPDFBitmap).
         smask = SkNEW_ARGS(PDFAlphaBitmap, (bm));
     }
     pdfBitmap = SkNEW_ARGS(SkPDFBitmap, (bm, smask));
     canon.addBitmap(pdfBitmap);
     return pdfBitmap;
 }