Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 9363010: Add a command-line switch "disable-desktop-shortcuts" to disable profile desktop shortcuts handling (Closed)

Created:
8 years, 10 months ago by Cem Kocagil
Modified:
8 years, 10 months ago
Reviewers:
SteveT
Visibility:
Public.

Description

Add a command-line switch "disable-desktop-shortcuts" to disable profile desktop shortcuts handling BUG=110206 TEST=Running chrome on Win with --disable-desktop-shortcuts and adding a new user shouldn't create a desktop shortcut Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Cem Kocagil
8 years, 10 months ago (2012-02-08 02:06:08 UTC) #1
Cem Kocagil
8 years, 10 months ago (2012-02-08 02:06:35 UTC) #2
Cem Kocagil
8 years, 10 months ago (2012-02-08 02:08:01 UTC) #3
SteveT
LGTM. Thanks for the patch, Cem! Are you familiar with how to get this through ...
8 years, 10 months ago (2012-02-08 15:34:30 UTC) #4
Cem Kocagil
Thanks! I think I have to check the commit box to add the patchset to ...
8 years, 10 months ago (2012-02-08 15:48:28 UTC) #5
SteveT
I don't think you have access to the CQ Checkbox, but I can check it ...
8 years, 10 months ago (2012-02-08 15:50:57 UTC) #6
Cem Kocagil
Okay, I added test instructions. http://www.chromium.org/developers/testing/commit-queue says "Yes, non-Chromium committers are allowed to use the ...
8 years, 10 months ago (2012-02-08 15:59:04 UTC) #7
SteveT
Oh, cool! I guess all you need is the LGTM. Hopefully we won't need an ...
8 years, 10 months ago (2012-02-08 16:20:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cem.kocagil@gmail.com/9363010/1
8 years, 10 months ago (2012-02-08 16:28:18 UTC) #9
commit-bot: I haz the power
Presubmit check for 9363010-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-08 16:28:20 UTC) #10
SteveT
We need an OWNERS LGTM :( Rachel, can you help us out?
8 years, 10 months ago (2012-02-08 16:37:02 UTC) #11
rpetterson
On 2012/02/08 16:37:02, SteveT wrote: > We need an OWNERS LGTM :( > > Rachel, ...
8 years, 10 months ago (2012-02-08 18:39:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cem.kocagil@gmail.com/9363010/1
8 years, 10 months ago (2012-02-08 18:51:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cem.kocagil@gmail.com/9363010/1
8 years, 10 months ago (2012-02-08 18:54:53 UTC) #14
commit-bot: I haz the power
8 years, 10 months ago (2012-02-08 21:56:51 UTC) #15
Change committed as 121063

Powered by Google App Engine
This is Rietveld 408576698