Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: src/objects.cc

Issue 936253002: Fixed incorrect generalization of types in Map::ReconfigureProperty() introduced in r26667. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index fd35c90e8d39049b7a5153339c697d84d90e6ca3..1842bb60ef050d5595f7441bb91b6e9b163c21a6 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2815,8 +2815,8 @@ Handle<Map> Map::ReconfigureProperty(Handle<Map> old_map, int modify_index,
Handle<HeapType> old_field_type =
GetFieldType(isolate, old_descriptors, i,
old_details.location(), next_representation);
- old_field_type =
- GeneralizeFieldType(old_field_type, next_field_type, isolate);
+ next_field_type =
+ GeneralizeFieldType(next_field_type, old_field_type, isolate);
}
} else {
Handle<HeapType> old_field_type =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698