Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: src/objects.cc

Issue 936253002: Fixed incorrect generalization of types in Map::ReconfigureProperty() introduced in r26667. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #include "src/accessors.h" 9 #include "src/accessors.h"
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 2797 matching lines...) Expand 10 before | Expand all | Expand 10 after
2808 2808
2809 if (next_location == kField) { 2809 if (next_location == kField) {
2810 if (next_kind == kData) { 2810 if (next_kind == kData) {
2811 Handle<HeapType> next_field_type; 2811 Handle<HeapType> next_field_type;
2812 if (modify_index == i) { 2812 if (modify_index == i) {
2813 next_field_type = new_field_type; 2813 next_field_type = new_field_type;
2814 if (!property_kind_reconfiguration) { 2814 if (!property_kind_reconfiguration) {
2815 Handle<HeapType> old_field_type = 2815 Handle<HeapType> old_field_type =
2816 GetFieldType(isolate, old_descriptors, i, 2816 GetFieldType(isolate, old_descriptors, i,
2817 old_details.location(), next_representation); 2817 old_details.location(), next_representation);
2818 old_field_type = 2818 next_field_type =
2819 GeneralizeFieldType(old_field_type, next_field_type, isolate); 2819 GeneralizeFieldType(next_field_type, old_field_type, isolate);
2820 } 2820 }
2821 } else { 2821 } else {
2822 Handle<HeapType> old_field_type = 2822 Handle<HeapType> old_field_type =
2823 GetFieldType(isolate, old_descriptors, i, old_details.location(), 2823 GetFieldType(isolate, old_descriptors, i, old_details.location(),
2824 next_representation); 2824 next_representation);
2825 next_field_type = old_field_type; 2825 next_field_type = old_field_type;
2826 } 2826 }
2827 2827
2828 DataDescriptor d(old_key, current_offset, next_field_type, 2828 DataDescriptor d(old_key, current_offset, next_field_type,
2829 next_attributes, next_representation); 2829 next_attributes, next_representation);
(...skipping 14372 matching lines...) Expand 10 before | Expand all | Expand 10 after
17202 CompilationInfo* info) { 17202 CompilationInfo* info) {
17203 Handle<DependentCode> codes = DependentCode::InsertCompilationInfo( 17203 Handle<DependentCode> codes = DependentCode::InsertCompilationInfo(
17204 handle(cell->dependent_code(), info->isolate()), 17204 handle(cell->dependent_code(), info->isolate()),
17205 DependentCode::kPropertyCellChangedGroup, info->object_wrapper()); 17205 DependentCode::kPropertyCellChangedGroup, info->object_wrapper());
17206 if (*codes != cell->dependent_code()) cell->set_dependent_code(*codes); 17206 if (*codes != cell->dependent_code()) cell->set_dependent_code(*codes);
17207 info->dependencies(DependentCode::kPropertyCellChangedGroup)->Add( 17207 info->dependencies(DependentCode::kPropertyCellChangedGroup)->Add(
17208 cell, info->zone()); 17208 cell, info->zone());
17209 } 17209 }
17210 17210
17211 } } // namespace v8::internal 17211 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698