<extensionview>: Set src as relative URL on loadcommit

This change sets the src as a relative URL instead of absolute URL on loadcommit.

Example: for "chrome-extension://extensionid/page.html",

Currently, the src would be set as: "chrome-extension://extensionid/page.html".

With the change, the src would be set as: "page.html".

BUG=459680
Committed: https://crrev.com/90db832274028991062574e66c8093cba1ff45a1
Cr-Commit-Position: refs/heads/master@{#316948}

[apacible, 2015-02-18 21:39:16]

Patchset #1 (id:1) has been deleted

[apacible, 2015-02-18 21:41:06]

apacible@chromium.org changed reviewers:
+ fsamuel@chromium.org

[apacible, 2015-02-18 21:42:50]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-02-18 21:43:10]

fsamuel, PTAL. Thanks!

[Fady Samuel, 2015-02-18 21:50:25]

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(right):

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:129: if
(!render_frame_host->GetParent())
Since you're only using this event to update the src attribute, I'd just exit
early here.

if (render_frame_host->GetParent())
  return;

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:137:
ReplaceFirstSubstringAfterOffset(&relative_url, 0, prefix, "");
Add the include for the header at the top.

[apacible, 2015-02-18 22:02:56]

Addressed comments. PTAL. Thanks!

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(right):

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:129: if
(!render_frame_host->GetParent())
On 2015/02/18 21:50:25, Fady Samuel wrote:
> Since you're only using this event to update the src attribute, I'd just exit
> early here.
> 
> if (render_frame_host->GetParent())
>   return;

Done.

https://codereview.chromium.org/936223002/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:137:
ReplaceFirstSubstringAfterOffset(&relative_url, 0, prefix, "");
On 2015/02/18 21:50:25, Fady Samuel wrote:
> Add the include for the header at the top.

Done.

[Fady Samuel, 2015-02-18 23:14:31]

lgtm

Please use the same bug number.

[Fady Samuel, 2015-02-18 23:15:28]

https://codereview.chromium.org/936223002/diff/60001/extensions/browser/guest...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(right):

https://codereview.chromium.org/936223002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:132: 
Oops, I think we lost updating the view_page_. Please add a line after:

view_page_ = url;

[apacible, 2015-02-18 23:19:50]

New patchsets have been uploaded after l-g-t-m from fsamuel@chromium.org

[apacible, 2015-02-18 23:20:34]

On 2015/02/18 23:14:31, Fady Samuel wrote:
> lgtm
> 
> Please use the same bug number.

Updated. Thanks!

[apacible, 2015-02-18 23:20:46]

https://codereview.chromium.org/936223002/diff/60001/extensions/browser/guest...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(right):

https://codereview.chromium.org/936223002/diff/60001/extensions/browser/guest...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:132: 
On 2015/02/18 23:15:28, Fady Samuel wrote:
> Oops, I think we lost updating the view_page_. Please add a line after:
> 
> view_page_ = url;

Done.

[apacible, 2015-02-18 23:25:52]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:27:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936223002/80001

[commit-bot: I haz the power, 2015-02-19 01:10:12]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-02-19 01:10:45]

Patchset 3 (id:??) landed as
https://crrev.com/90db832274028991062574e66c8093cba1ff45a1
Cr-Commit-Position: refs/heads/master@{#316948}