<extensionview>: Set src as relative URL on loadcommit

extensions/browser/guest_view/extension_view/extension_view_guest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/extension_view/extension_view_guest.h"
 
 #include "base/metrics/user_metrics.h"
 #include "components/crx_file/id_util.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/common/result_codes.h"
@@ skipping 108 matching lines @@
 
 int ExtensionViewGuest::GetTaskPrefix() const {
   return IDS_EXTENSION_TASK_MANAGER_EXTENSIONVIEW_TAG_PREFIX;
 }
 
 // content::WebContentsObserver implementation.
 void ExtensionViewGuest::DidCommitProvisionalLoadForFrame(
     content::RenderFrameHost* render_frame_host,
     const GURL& url,
     ui::PageTransition transition_type) {
   if (!render_frame_host->GetParent())

[Fady Samuel, 2015/02/18 21:50:25]

Since you're only using this event to update the src attribute, I'd just exit
early here.

if (render_frame_host->GetParent())
  return;

[apacible, 2015/02/18 22:02:56]

Done.

     view_page_ = url;
 
+  // Gets chrome-extension://extensionid/ prefix.
+  std::string prefix = url.GetWithEmptyPath().spec();
+  std::string relative_url = url.spec();
+
+  // Removes the prefix.
+  ReplaceFirstSubstringAfterOffset(&relative_url, 0, prefix, "");

[Fady Samuel, 2015/02/18 21:50:25]

Add the include for the header at the top.

[apacible, 2015/02/18 22:02:56]

Done.

+
   scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
-  args->SetString(guestview::kUrl, url.spec());
+  args->SetString(guestview::kUrl, relative_url);
   DispatchEventToView(
       new GuestViewBase::Event(extensionview::kEventLoadCommit, args.Pass()));
 }
 
 void ExtensionViewGuest::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   if (attached() && (params.url.GetOrigin() != view_page_.GetOrigin())) {
     base::RecordAction(base::UserMetricsAction("BadMessageTerminate_EVG"));
     web_contents()->GetRenderProcessHost()->Shutdown(
@@ skipping 17 matching lines @@
                                            web_contents()->GetRenderViewHost());
 }
 
 void ExtensionViewGuest::ApplyAttributes(const base::DictionaryValue& params) {
   std::string src;
   params.GetString(extensionview::kAttributeSrc, &src);
   NavigateGuest(src, false /* force_navigation */);
 }
 
 }  // namespace extensions