Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 936193005: Make it possible to inherit from any constructable host object (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to inherit from any constructable host object This CL makes it possible for authors to extend any host object (e.g., DOM objects) and to use those objects in all the usual places they can be used in the API. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cfb583a26e7415b26c28cab38dde1bd87d68c4cd

Patch Set 1 #

Patch Set 2 : Now with tests #

Patch Set 3 : Remove extra comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -11 lines) Patch
M sky/engine/bindings/scripts/dart_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/templates/interface_dart.template View 1 chunk +6 lines, -5 lines 0 comments Download
M sky/engine/bindings/scripts/templates/methods_cpp.template View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M sky/engine/tonic/dart_wrappable.h View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/tonic/dart_wrappable.cc View 1 chunk +23 lines, -0 lines 2 comments Download
A sky/tests/dom/inherit-from-text.sky View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + sky/tests/dom/inherit-from-text-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-19 21:01:24 UTC) #1
esprehn
lgtm, I'm not super familiar with the generator but it looks okay. What's the one_based ...
5 years, 10 months ago (2015-02-20 06:56:10 UTC) #2
abarth-chromium
> What's the one_based stuff about though? For non-static functions, the 0th argument is the ...
5 years, 10 months ago (2015-02-20 07:00:34 UTC) #3
abarth-chromium
On 2015/02/20 at 07:00:34, abarth wrote: > Yes. Always two there are. One is the ...
5 years, 10 months ago (2015-02-20 07:01:22 UTC) #4
abarth-chromium
5 years, 10 months ago (2015-02-20 07:09:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cfb583a26e7415b26c28cab38dde1bd87d68c4cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698