sky/engine/bindings/scripts/dart_methods.py - Issue 936193005: Make it possible to inherit from any constructable host object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/dart_methods.py

Issue 936193005: Make it possible to inherit from any constructable host object (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Remove extra comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/dart_methods.py

diff --git a/sky/engine/bindings/scripts/dart_methods.py b/sky/engine/bindings/scripts/dart_methods.py

index 014f28b7b49e7f29495ee11812e2ec08e6b36bd3..3ce01527852be14a7fab423fed3e147ca09861e2 100644

--- a/sky/engine/bindings/scripts/dart_methods.py

+++ b/sky/engine/bindings/scripts/dart_methods.py

@@ -106,7 +106,7 @@ def argument_context(interface, method, argument, index):

idl_type = argument.idl_type

this_cpp_value = cpp_value(interface, method, index)

auto_scope = not 'DartNoAutoScope' in extended_attributes

- arg_index = index + 1 if not (method.is_static or method.is_constructor) else index

+ arg_index = index + 1 if not method.is_static else index

preprocessed_type = str(idl_type.preprocessed_type)

local_cpp_type = idl_type.cpp_type_args(argument.extended_attributes, raw_type=True)

default_value = argument.default_cpp_value