Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 936123002: [Extensions] Implement chrome.runtime.openOptionsPage. (Closed)

Created:
5 years, 10 months ago by not at google - send to devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Implement chrome.runtime.openOptionsPage. BUG=430054 R=rockot@chromium.org Committed: https://crrev.com/ce22c477cd86c9edfe564083dc244c44e18b0caa Cr-Commit-Position: refs/heads/master@{#316975}

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : default impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -5 lines) Patch
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +5 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/runtime/open_options_page/manifest.json View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/runtime/open_options_page/options.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/runtime/open_options_page/options.js View 1 1 chunk +2 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/runtime/open_options_page/test.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/runtime/open_options_page_error/manifest.json View 1 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/runtime/open_options_page_error/test.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.h View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api_delegate.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api_delegate.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_apitest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/runtime.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
not at google - send to devlin
Well this was more effort than I expected.
5 years, 10 months ago (2015-02-18 17:06:31 UTC) #1
Ken Rockot(use gerrit already)
Doesn't seem too bad. Maybe we should (not now) let the delegate specify default implementations ...
5 years, 10 months ago (2015-02-18 20:47:47 UTC) #2
Ken Rockot(use gerrit already)
On 2015/02/18 20:47:47, Ken Rockot wrote: > Doesn't seem too bad. Maybe we should (not ...
5 years, 10 months ago (2015-02-18 20:48:26 UTC) #3
not at google - send to devlin
On 2015/02/18 20:48:26, Ken Rockot wrote: > On 2015/02/18 20:47:47, Ken Rockot wrote: > > ...
5 years, 10 months ago (2015-02-18 21:05:08 UTC) #4
not at google - send to devlin
isherman for histogramx.
5 years, 10 months ago (2015-02-18 21:54:52 UTC) #7
Ilya Sherman
histogramx lgtm
5 years, 10 months ago (2015-02-19 00:20:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936123002/40001
5 years, 10 months ago (2015-02-19 00:37:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 02:31:50 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 02:32:47 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce22c477cd86c9edfe564083dc244c44e18b0caa
Cr-Commit-Position: refs/heads/master@{#316975}

Powered by Google App Engine
This is Rietveld 408576698