chrome/browser/extensions/extension_tab_util.h - Issue 936123002: [Extensions] Implement chrome.runtime.openOptionsPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.h

Issue 936123002: [Extensions] Implement chrome.runtime.openOptionsPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: default impl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tab_util.h

diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h

index 5a45abf8283c9a61a38326d2ad602b2eac72ea15..6736db442ff8cf27c886c039cb1db1f363403c20 100644

--- a/chrome/browser/extensions/extension_tab_util.h

+++ b/chrome/browser/extensions/extension_tab_util.h

@@ -171,8 +171,10 @@ class ExtensionTabUtil {

static WindowController* GetWindowControllerOfTab(

const content::WebContents* web_contents);

- // Open the extension's options page.

- static void OpenOptionsPage(const Extension* extension, Browser* browser);

+ // Open the extension's options page. Returns true if an options page was

+ // successfully opened (though it may not necessarily *load*, e.g. if the

+ // URL does not exist).

+ static bool OpenOptionsPage(const Extension* extension, Browser* browser);

};

} // namespace extensions