Remove unused errno parsing for leveldb status codes

third_party/leveldatabase/env_chromium_unittest.cc

Index: third_party/leveldatabase/env_chromium_unittest.cc
diff --git a/third_party/leveldatabase/env_chromium_unittest.cc b/third_party/leveldatabase/env_chromium_unittest.cc
index 72a1efb3af355317d3e0709f82ab3878201a3b2b..45ca84338776747e4db8b0fcb262d009131ef9f4 100644
--- a/third_party/leveldatabase/env_chromium_unittest.cc
+++ b/third_party/leveldatabase/env_chromium_unittest.cc
@@ -31,10 +31,10 @@ TEST(ErrorEncoding, OnlyAMethod) {
   const MethodID in_method = leveldb_env::kSequentialFileRead;
   const Status s = MakeIOError("Somefile.txt", "message", in_method);
   MethodID method;
-  int error = -75;
+  base::File::Error error = base::File::FILE_OK;

[jsbell, 2015/02/19 19:56:51]

I thought about using base::File::FILE_ERROR_MAX here instead. Or I could
static_cast<>. Opinions?

[cmumford, 2015/02/20 19:21:24]

I guess the original intent of -75 was to verify that the error value was
unchanged as method errors don't have a number. I'd probably use anything but
FILE_OK (0) and would probably go with FILE_ERROR_MAX.

[jsbell, 2015/02/20 20:03:40]

Agreed. Given that we should never assign FILE_ERROR_MAX I'll go with that.

   EXPECT_EQ(leveldb_env::METHOD_ONLY, ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(in_method, method);
-  EXPECT_EQ(-75, error);
+  EXPECT_EQ(base::File::FILE_OK, error);
 }
 
 TEST(ErrorEncoding, FileError) {
@@ -42,7 +42,7 @@ TEST(ErrorEncoding, FileError) {
   const base::File::Error fe = base::File::FILE_ERROR_INVALID_OPERATION;
   const Status s = MakeIOError("Somefile.txt", "message", in_method, fe);
   MethodID method;
-  int error;
+  base::File::Error error;
   EXPECT_EQ(leveldb_env::METHOD_AND_PFE,
             ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(in_method, method);
@@ -52,10 +52,10 @@ TEST(ErrorEncoding, FileError) {
 TEST(ErrorEncoding, NoEncodedMessage) {
   Status s = Status::IOError("Some message", "from leveldb itself");
   MethodID method = leveldb_env::kRandomAccessFileRead;
-  int error = 4;
+  base::File::Error error = base::File::FILE_OK;
   EXPECT_EQ(leveldb_env::NONE, ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(leveldb_env::kRandomAccessFileRead, method);
-  EXPECT_EQ(4, error);
+  EXPECT_EQ(base::File::FILE_OK, error);
 }
 
 template <typename T>