Remove unused errno parsing for leveldb status codes

third_party/leveldatabase/env_chromium_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/test/test_suite.h"
@@ skipping 13 matching lines @@
 using leveldb::Status;
 using leveldb::WritableFile;
 using leveldb::WriteOptions;
 using leveldb_env::ChromiumEnv;
 using leveldb_env::MethodID;
 
 TEST(ErrorEncoding, OnlyAMethod) {
   const MethodID in_method = leveldb_env::kSequentialFileRead;
   const Status s = MakeIOError("Somefile.txt", "message", in_method);
   MethodID method;
-  int error = -75;
+  base::File::Error error = base::File::FILE_OK;

[jsbell, 2015/02/19 19:56:51]

I thought about using base::File::FILE_ERROR_MAX here instead. Or I could
static_cast<>. Opinions?

[cmumford, 2015/02/20 19:21:24]

I guess the original intent of -75 was to verify that the error value was
unchanged as method errors don't have a number. I'd probably use anything but
FILE_OK (0) and would probably go with FILE_ERROR_MAX.

[jsbell, 2015/02/20 20:03:40]

Agreed. Given that we should never assign FILE_ERROR_MAX I'll go with that.

   EXPECT_EQ(leveldb_env::METHOD_ONLY, ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(in_method, method);
-  EXPECT_EQ(-75, error);
+  EXPECT_EQ(base::File::FILE_OK, error);
 }
 
 TEST(ErrorEncoding, FileError) {
   const MethodID in_method = leveldb_env::kWritableFileClose;
   const base::File::Error fe = base::File::FILE_ERROR_INVALID_OPERATION;
   const Status s = MakeIOError("Somefile.txt", "message", in_method, fe);
   MethodID method;
-  int error;
+  base::File::Error error;
   EXPECT_EQ(leveldb_env::METHOD_AND_PFE,
             ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(in_method, method);
   EXPECT_EQ(fe, error);
 }
 
 TEST(ErrorEncoding, NoEncodedMessage) {
   Status s = Status::IOError("Some message", "from leveldb itself");
   MethodID method = leveldb_env::kRandomAccessFileRead;
-  int error = 4;
+  base::File::Error error = base::File::FILE_OK;
   EXPECT_EQ(leveldb_env::NONE, ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(leveldb_env::kRandomAccessFileRead, method);
-  EXPECT_EQ(4, error);
+  EXPECT_EQ(base::File::FILE_OK, error);
 }
 
 template <typename T>
 class MyEnv : public T {
  public:
   MyEnv() : directory_syncs_(0) {}
   int directory_syncs() { return directory_syncs_; }
 
  protected:
   virtual void DidSyncDir(const std::string& fname) {
@@ skipping 153 matching lines @@
   EXPECT_TRUE(status.ok());
   EXPECT_EQ(1U, result.size());
 
   // And a second time should also return one result
   status = env->GetChildren(dir.AsUTF8Unsafe(), &result);
   EXPECT_TRUE(status.ok());
   EXPECT_EQ(1U, result.size());
 }
 
 int main(int argc, char** argv) { return base::TestSuite(argc, argv).Run(); }