Upstream privacy settings.

Upstream privacy settings.

This upstreams the privacy screen in settings, which includes navigation
error suggestions, omnibox suggestions, prefetching, crash report
uploading, do not track, and clearing data.

BUG=428869
Committed: https://crrev.com/d700c0f0a3bdaf321db6f30010c59f4ed6a54176
Cr-Commit-Position: refs/heads/master@{#317086}

[newt (away), 2015-02-18 03:07:55]

newt@chromium.org changed reviewers:
+ bnc@chromium.org, tedchoc@chromium.org

[newt (away), 2015-02-18 03:07:55]

PTAL

bnc: PrivacyPreferencesManager[Test].java, NetworkPredictionPreference.java,
CrashDumpUploadPreference.java, arrays.xml, and related bits of
android_chrome_strings.grd

tedchoc: everything else (ClearBrowsingDataDialogFragment.java,
ContextualSearchPreferenceFragment.java, DoNotTrackPreference.java and XML
files)

[newt (away), 2015-02-18 03:12:47]

Everything here is copy-pasted from downstream except for these changes:
 - Added several methods to Preferences.java to allow delegation to a downstream
implementation
 - Used a HyperlinkPreferences to simplify do_not_track_preferences.xml
(explanation here: https://codereview.chromium.org/933063002)

[Ted C, 2015-02-18 16:28:38]

lgtm

https://codereview.chromium.org/935903002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
(right):

https://codereview.chromium.org/935903002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java:85:
public void logContextualSearchToggled(boolean newValue) {}
should all of these have TODO/bugs associated with them to address it?  For
example, upstream contextual search.  Upstream EmbedContentViewActivity (I
assume that is what showPrivacyPreferencesHelp is intended to do below).

Might give these a bit more of an actionable way to address them.

[newt (away), 2015-02-18 19:21:21]

New patchsets have been uploaded after l-g-t-m from tedchoc@chromium.org

[newt (away), 2015-02-18 19:23:29]

https://codereview.chromium.org/935903002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
(right):

https://codereview.chromium.org/935903002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java:85:
public void logContextualSearchToggled(boolean newValue) {}
On 2015/02/18 16:28:38, Ted C wrote:
> should all of these have TODO/bugs associated with them to address it?  For
> example, upstream contextual search.  Upstream EmbedContentViewActivity (I
> assume that is what showPrivacyPreferencesHelp is intended to do below).
> 
> Might give these a bit more of an actionable way to address them.

Yes-ish. I'll add TODOs.

[newt (away), 2015-02-18 23:46:22]

bnc: ping

[Bence, 2015-02-19 17:03:19]

LGTM.  Sorry for the delay.

[newt (away), 2015-02-19 18:37:41]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-02-19 18:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935903002/60001

[commit-bot: I haz the power, 2015-02-19 19:00:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-19 19:00:55]

Patchset 4 (id:??) landed as
https://crrev.com/d700c0f0a3bdaf321db6f30010c59f4ed6a54176
Cr-Commit-Position: refs/heads/master@{#317086}