Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 933063002: Use HyperlinkPreference where applicable. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use HyperlinkPreference where applicable. Settings contains several "learn more" links that are actually preference objects. These were originally implemented as TextMessagePreferences with some ad-hoc logic to change the text formatting and click handling. Now we have a dedicated HyperlinkPreference class to encapsulate this logic, so use it. Committed: https://crrev.com/a135cb4208f3543ab144ff7f3f25df3a09dd5bb7 Cr-Commit-Position: refs/heads/master@{#316715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -63 lines) Patch
M chrome/android/java/res/xml/bandwidth_reduction_preferences_off.xml View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/android/java/res/xml/protected_content_preferences.xml View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentPreferences.java View 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/bandwidth/BandwidthReductionPreferences.java View 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-02-18 00:03:38 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-02-18 00:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933063002/1
5 years, 10 months ago (2015-02-18 00:29:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 00:55:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 00:56:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a135cb4208f3543ab144ff7f3f25df3a09dd5bb7
Cr-Commit-Position: refs/heads/master@{#316715}

Powered by Google App Engine
This is Rietveld 408576698