Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 935843007: Remove unused parameters to SkDocument::CreatePDF (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused parameters to SkDocument::CreatePDF All image compression currently uses (losseless) Deflate, not Jpeg. All clients simply use SkDocument::CreatePDF(stream). SampleApp and SkLua still use SkDocument::CreatePDF(path). Committed: https://skia.googlesource.com/skia/+/8c92dc1dc281649f9e6b0ff534c25bc89dded3ea

Patch Set 1 #

Patch Set 2 : remove SkPicture::EncodeBitmap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -113 lines) Patch
M include/core/SkDocument.h View 2 chunks +25 lines, -41 lines 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/doc/SkDocument_PDF.cpp View 3 chunks +11 lines, -21 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFImage.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/render_pdfs_main.cpp View 4 chunks +3 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hal.canary
ptal
5 years, 10 months ago (2015-02-19 19:36:22 UTC) #2
reed1
What is the state of handling uncompressed images w/ this CL?
5 years, 10 months ago (2015-02-19 20:25:56 UTC) #3
hal.canary
noted
5 years, 10 months ago (2015-02-19 20:27:41 UTC) #4
reed1
lgtm
5 years, 10 months ago (2015-02-19 20:58:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935843007/20001
5 years, 10 months ago (2015-02-19 20:58:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2581)
5 years, 10 months ago (2015-02-19 21:00:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935843007/20001
5 years, 10 months ago (2015-02-19 21:08:36 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 02:50:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8c92dc1dc281649f9e6b0ff534c25bc89dded3ea

Powered by Google App Engine
This is Rietveld 408576698