Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tools/render_pdfs_main.cpp

Issue 935843007: Remove unused parameters to SkDocument::CreatePDF (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove SkPicture::EncodeBitmap Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pdf/SkPDFImage.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/render_pdfs_main.cpp
diff --git a/tools/render_pdfs_main.cpp b/tools/render_pdfs_main.cpp
index 678787780bff7846af76cee0baa95046a4386454..4820a335f41b52222d51d14425b1f0ee663eb6e1 100644
--- a/tools/render_pdfs_main.cpp
+++ b/tools/render_pdfs_main.cpp
@@ -56,11 +56,6 @@ DEFINE_string2(match, m, "",
"If a file does not match any list entry,\n"
"it is skipped unless some list entry starts with ~");
-DEFINE_int32(jpegQuality, 100,
- "Encodes images in JPEG at quality level N, which can be in "
- "range 0-100). N = -1 will disable JPEG compression. "
- "Default is N = 100, maximum quality.");
-
/** Replaces the extension of a file.
* @param path File name whose extension will be changed.
* @param old_extension The old extension.
@@ -83,25 +78,6 @@ static bool replace_filename_extension(SkString* path,
return false;
}
-// the size_t* parameter is deprecated, so we ignore it
-static SkData* encode_to_dct_data(size_t*, const SkBitmap& bitmap) {
- if (FLAGS_jpegQuality == -1) {
- return NULL;
- }
-
- SkBitmap bm = bitmap;
-#if defined(SK_BUILD_FOR_MAC)
- // Workaround bug #1043 where bitmaps with referenced pixels cause
- // CGImageDestinationFinalize to crash
- SkBitmap copy;
- bitmap.deepCopyTo(&copy);
- bm = copy;
-#endif
-
- return SkImageEncoder::EncodeData(
- bm, SkImageEncoder::kJPEG_Type, FLAGS_jpegQuality);
-}
-
/** Builds the output filename. path = dir/name, and it replaces expected
* .skp extension with .pdf extention.
* @param path Output filename.
@@ -162,10 +138,9 @@ static SkWStream* open_stream(const SkString& outputDir,
* output, using the provided encoder.
*/
static bool pdf_to_stream(SkPicture* picture,
- SkWStream* output,
- SkPicture::EncodeBitmap encoder) {
+ SkWStream* output) {
SkAutoTUnref<SkDocument> pdfDocument(
- SkDocument::CreatePDF(output, NULL, encoder));
+ SkDocument::CreatePDF(output));
SkCanvas* canvas = pdfDocument->beginPage(picture->cullRect().width(),
picture->cullRect().height());
canvas->drawPicture(picture);
@@ -264,7 +239,7 @@ int tool_main_core(int argc, char** argv) {
++failures;
continue;
}
- if (!pdf_to_stream(picture, stream.get(), encode_to_dct_data)) {
+ if (!pdf_to_stream(picture, stream.get())) {
SkDebugf("Error in PDF Serialization.");
++failures;
}
« no previous file with comments | « src/pdf/SkPDFImage.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698