chrome/browser/net/certificate_error_reporter.h - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/certificate_error_reporter.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use SecurityInterstitialMetricsHelper for extended reporting events Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/security_interstitial_page.h ('K') | « chrome/browser/interstitials/security_interstitial_page.cc ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | chrome/browser/safe_browsing/ping_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/certificate_error_reporter.h

diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h

index 5463d5a74bd69d6286bbb8cbe1115fc78e8bcd41..3eaf1747405e9f0cd2ceaa6bf69be2f54230f080 100644

--- a/chrome/browser/net/certificate_error_reporter.h

+++ b/chrome/browser/net/certificate_error_reporter.h

@@ -22,6 +22,8 @@ namespace chrome_browser_net {

class CertLoggerRequest;

+extern const char kExtendedReportingUploadUrl[];

// Provides functionality for sending reports about invalid SSL

// certificate chains to a report collection server.

class CertificateErrorReporter : public net::URLRequest::Delegate {

@@ -44,7 +46,7 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {

~CertificateErrorReporter() override;

- // Construct, serialize, and send a certificate reporter to the report

+ // Construct, serialize, and send a certificate report to the report

// collection server containing the |ssl_info| associated with a

// connection to |hostname|.

virtual void SendReport(ReportType type,