Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2220)

Unified Diff: chrome/browser/net/certificate_error_reporter.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use SecurityInterstitialMetricsHelper for extended reporting events Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter.cc
diff --git a/chrome/browser/net/certificate_error_reporter.cc b/chrome/browser/net/certificate_error_reporter.cc
index 57e737fce6d530e8c87fdbab7736527ab0d8a418..d3359629a56f8bd6a04eb152601e8efa230b3e4b 100644
--- a/chrome/browser/net/certificate_error_reporter.cc
+++ b/chrome/browser/net/certificate_error_reporter.cc
@@ -20,6 +20,10 @@
namespace chrome_browser_net {
+// URL to upload invalid certificate chain reports
+// TODO(estark): Fill this in with the real URL when live.
+const char kExtendedReportingUploadUrl[] = "http://example.test";
+
CertificateErrorReporter::CertificateErrorReporter(
net::URLRequestContext* request_context,
const GURL& upload_url)
@@ -47,8 +51,7 @@ void CertificateErrorReporter::SendReport(ReportType type,
// TODO(estark): Double-check that the user is opted in.
// TODO(estark): Temporarily, since this is no upload endpoint, just
// log the information.
- request.SerializeToString(&out);
- DVLOG(3) << "SSL report for " << hostname << ":\n" << out << "\n\n";
+ DVLOG(1) << "Would send certificate report for " << hostname;
break;
default:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698