Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: net/url_request/fraudulent_certificate_reporter.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test for not sending reports when flag is disabled Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/fraudulent_certificate_reporter.h
diff --git a/net/url_request/fraudulent_certificate_reporter.h b/net/url_request/fraudulent_certificate_reporter.h
index 8d5d60a0ef151769355e0995ffc01714b65c8884..236240039a532156475c420953a5c0ddfd73d7fe 100644
--- a/net/url_request/fraudulent_certificate_reporter.h
+++ b/net/url_request/fraudulent_certificate_reporter.h
@@ -16,15 +16,17 @@ class SSLInfo;
// check.
class FraudulentCertificateReporter {
public:
+ enum ReportType { REPORT_TYPE_PIN_VIOLATION, REPORT_TYPE_EXTENDED_REPORTING };
felt 2015/02/24 01:57:53 nit: I've never seen an enum formatted like this.
estark 2015/02/24 18:47:09 This is another thing that 'git cl format' undoes.
+
virtual ~FraudulentCertificateReporter() {}
// Sends a report to the report collection server containing the |ssl_info|
// associated with a connection to |hostname|.
- virtual void SendReport(const std::string& hostname,
+ virtual void SendReport(ReportType type,
+ const std::string& hostname,
const SSLInfo& ssl_info) = 0;
};
} // namespace net
#endif // NET_URL_REQUEST_FRAUDULENT_CERTIFICATE_REPORTER_H_
-

Powered by Google App Engine
This is Rietveld 408576698