net/url_request/url_request_http_job.cc - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test for not sending reports when flag is disabled Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/fraudulent_certificate_reporter.h ('K') | « net/url_request/fraudulent_certificate_reporter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index f46b5ab631b4a961f82b71476894dcaea1ebdce9..240efda7990ba7e0ac2e4503b7195ce1b9161aa0 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -866,7 +866,9 @@ void URLRequestHttpJob::OnStartCompleted(int result) {

const SSLInfo& ssl_info = transaction_->GetResponseInfo()->ssl_info;

const std::string& host = request_->url().host();

- reporter->SendReport(host, ssl_info);

+ reporter->SendReport(

+ FraudulentCertificateReporter::REPORT_TYPE_PIN_VIOLATION, host,

+ ssl_info);

}