chrome/browser/ssl/captive_portal_blocking_page.h - Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test for not sending reports when flag is disabled Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/security_warnings/safe_browsing.js ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | chrome/browser/ssl/ssl_blocking_page.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/captive_portal_blocking_page.h

diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h

index 0b150cb6f3fb19683bd53b2721d10b8cb365488d..1510fed6e798e29cfd70aa45d50a075133aed509 100644

--- a/chrome/browser/ssl/captive_portal_blocking_page.h

+++ b/chrome/browser/ssl/captive_portal_blocking_page.h

@@ -55,6 +55,9 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {

void PopulateInterstitialStrings(

base::DictionaryValue* load_time_data) override;

bool ShouldCreateNewNavigation() const override;

+ // Extended reporting is not enabled for captive portal interstitials.

+ void PopulateExtendedReportingOption(

+ base::DictionaryValue* load_time_data) override{};

felt 2015/02/24 01:57:53 nit: missing a space?

estark 2015/02/24 18:47:09 Hmm, 'git cl format' removes it if I add a space t

// InterstitialPageDelegate method:

void CommandReceived(const std::string& command) override;