Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Side by Side Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 935663004: Add checkbox for reporting invalid TLS/SSL cert chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test for not sending reports when flag is disabled Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_ 5 #ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_ 6 #define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // SecurityInterstitialPage method: 48 // SecurityInterstitialPage method:
49 const void* GetTypeForTesting() const override; 49 const void* GetTypeForTesting() const override;
50 50
51 void SetDelegateForTesting(Delegate* delegate) { delegate_.reset(delegate); } 51 void SetDelegateForTesting(Delegate* delegate) { delegate_.reset(delegate); }
52 52
53 protected: 53 protected:
54 // SecurityInterstitialPage methods: 54 // SecurityInterstitialPage methods:
55 void PopulateInterstitialStrings( 55 void PopulateInterstitialStrings(
56 base::DictionaryValue* load_time_data) override; 56 base::DictionaryValue* load_time_data) override;
57 bool ShouldCreateNewNavigation() const override; 57 bool ShouldCreateNewNavigation() const override;
58 // Extended reporting is not enabled for captive portal interstitials.
59 void PopulateExtendedReportingOption(
60 base::DictionaryValue* load_time_data) override{};
felt 2015/02/24 01:57:53 nit: missing a space?
estark 2015/02/24 18:47:09 Hmm, 'git cl format' removes it if I add a space t
58 61
59 // InterstitialPageDelegate method: 62 // InterstitialPageDelegate method:
60 void CommandReceived(const std::string& command) override; 63 void CommandReceived(const std::string& command) override;
61 64
62 private: 65 private:
63 // URL of the login page, opened when the user clicks the "Connect" button. 66 // URL of the login page, opened when the user clicks the "Connect" button.
64 GURL login_url_; 67 GURL login_url_;
65 scoped_ptr<Delegate> delegate_; 68 scoped_ptr<Delegate> delegate_;
66 base::Callback<void(bool)> callback_; 69 base::Callback<void(bool)> callback_;
67 70
68 DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage); 71 DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
69 }; 72 };
70 73
71 #endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_ 74 #endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698