Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: src/deoptimizer.cc

Issue 935623002: Convert to immutable heap number when materializing arguments object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-457935.js » ('j') | test/mjsunit/regress/regress-457935.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index 7c79c89078b98a74e8d65bfb766e2670a8850ba4..befb0f3b85acf264b312e02ea902f5480903625f 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -3389,7 +3389,11 @@ Handle<Object> SlotRefValueBuilder::GetNext(Isolate* isolate, int lvl) {
case SlotRef::UINT32:
case SlotRef::DOUBLE:
case SlotRef::LITERAL: {
- return slot.GetValue(isolate);
+ Handle<Object> value = slot.GetValue(isolate);
+ if (value->IsMutableHeapNumber()) {
Igor Sheludko 2015/02/17 15:07:54 I think we could save some cycles if we put this c
Jarin 2015/02/17 15:20:48 Done. (Even though there is so much stuff going on
+ HeapNumber::cast(*value)->set_map(isolate->heap()->heap_number_map());
+ }
+ return value;
}
case SlotRef::ARGUMENTS_OBJECT: {
// We should never need to materialize an arguments object,
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-457935.js » ('j') | test/mjsunit/regress/regress-457935.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698